Nakama-js throws uncatcheable exception

Client Libraries
,
1

I made a PR for this, but the README says I should also post here. Here’s the issue:

We are seeing errors in production where this code in socket.ts:

this.adapter.onError = (evt) => {
        reject(evt);
        this.adapter.close();
};

Calls this:

close() {
    this._socket.close();
    this._socket = void 0;
}

But this._socket is undefined and throws an error. This throws a TypeError inside of a Promise constructor, which is then unhandled because the promise is already rejected. This can be demonstrated very succinctly with this bit of code:

const foo = () => new Promise((res, rej) => {
  rej('Error A');

  throw new Error('Error B');
});

const run = async () => {
  try {
    await foo();
  } catch(error) {
    console.log('Caught an error: ' + error);
  }
};

run();

This will output: Caught an error: Error A, whereas Error B cannot be handled.

To fix this, mirroring all other calls to this.adapter.close(), we simply need to wrap with a check that the adapter is indeed open.

2

Does anyone know how we are supposed to report breaking bugs if not here?

3

Hello @thegoldenmule,

The PR was accepted, thank you for the contribution.

1 Like